Tweaks...
You need to be logged in to post messages in the forums. New users may register here.
|
Bruce Morrison
Member since:
09 January 2008
Posts: 37
|
Wednesday 06 February 2008 1:01:21 am
Hi Damien
Nice extension!
I had to make some changes to get it going here...
In extension/ezvideoflv/design/standard/templates/content/datatype/view/ezvideoflv.tpl
<param name="FlashVars" value="flv={$flv|ezurl('no')}&startimage={$preview|ezroot('no')}{$opt_string}" />
to
<param name="FlashVars" value="flv={$flv|ezurl('no')}&startimage={$preview|ezurl('no')}{$opt_string}" />
and to negate the need to give users permissions....should be handled by the content module(?)
Add
|
|
|
Damien Pobel
Member since:
09 January 2008
Posts: 28
|
Wednesday 06 February 2008 3:21:51 am
Hi Bruce,
For the template code, you're right, it's a small bug, I'll correct it in the next release.
For the second point, I'll add it to the documentation because I like to be able to choose if I want anonymous access or not.
Thanks for your comment :-)
Cheers
|
|
|
Bruce Morrison
Member since:
09 January 2008
Posts: 37
|
Wednesday 06 February 2008 3:23:49 pm
Hi Damien
For the template code, you're right, it's a small bug, I'll correct it in the next release. No Problem ...that's open source for ya ;)
Regarding the permissions etc my thinking was that if the user has read access to the node/object that contains the datatype then there is no reason that that should have to have extra permissions to access the video?
It appears that this code is already in both flv.php & preview.php:
|
|
|
Damien Pobel
Member since:
09 January 2008
Posts: 28
|
Thursday 07 February 2008 8:24:44 am
Hi Bruce,
In fact, when I wrote the code I was thinking of the following situation :
you have a content class with for example a title, a description, keywords and a video. You give read access to anonymous users on objects of this class, but you only want logged users to see the video and the preview.
I even think that there should be video/preview and video/read functions that give more flexibility. And if you don't want permission related problem, there's the solution you mentioned.
Anyway, I correct the bug in templates and add a comment in the site.ini.append.php in the SVN thanks for your report.
|
|
You need to be logged in to post messages in the forums. New users may register here.
